OAE Release and Email

[Carl Hall]

That patch was a blind change to use the existing function which now shows
that it hasn't been updated in ages. It will need updating based on this
conversation and others.

If the email address lives on the user (ie. basic info), then that's a quick
lookup. If the email address lives somewhere else, we need some way to know
where that is as scanning the whole profile doesn't seem feasible.
Should there be a field somewhere that says, "here is where the system can
find a user's email address"?


On Mon, Aug 15, 2011 at 12:43 PM, Ian Boston <ieb at tfd.co.uk> wrote:

> Looks like the patch [1] isnt looking at the user at all, its looking
> at the profile and hoping that its being synced with the User.
>
> I suspect that this is due to the fact that no one really knows where
> this information should be stored by default so we keep flip flopping
> from one location to another depending on who made the last commit,
> and if the moon was in a particular phase. (ie random). Is there any
> documentation on what the standard is.... anywhere ?
>
> IMHO the patch should look at the user first, and if the information
> is not there it should look at the profile, but we should not rely on
> it being in the profile. This information is BasicUserInfo by default.
>
> On 15 August 2011 16:31, N. Matthijs <nicolaas.matthijs at caret.cam.ac.uk>
> wrote:
> > Given that most institutions will move email out of the basic
> > info section, we should make sure that the patch is able
> > to find the email address in other profile sections as well.
> >
> > Nicolaas
> >
> >> https://jira.sakaiproject.org/browse/KERN-2165
> >>
> >>
> >> On Mon, Aug 15, 2011 at 7:50 AM, Carl Hall <carl at hallwaytech.com>
> wrote:
> >>
> >>> Is there a JIRA for this? I have a fix ready to be reviewed.
> >>>
> >>>
> >>> On Mon, Aug 15, 2011 at 5:49 AM, Ian Boston <ieb at tfd.co.uk> wrote:
> >>>
> >>>> On 15 August 2011 06:26, David Roma <david.roma.csu at gmail.com> wrote:
> >>>> >               LOG.debug("Message is an SMTP Message, getting email
> >>>> address
> >>>> > for the user {}", user.getId());
> >>>> >               // TODO PersonalUtils not yet implemented for Sparse
> >>>> >               // String rcptEmailAddress =
> >>>> > PersonalUtils.getPrimaryEmailAddress(profileNode);
> >>>> >               String rcptEmailAddress = "someguy at example.com";
> >>>>
> >>>>
> >>>> If this is in the current code base.... it must be a blocker for a
> >>>> release
> >>>> ?
> >>>>
> >>>> Why didnt it get spotted earlier ?
> >>>> I did some testing a few weeks ago, and IIRC, once the user had set
> >>>> and email... it worked, but I could have been dreaming.
> >>>> Ian
> >>>> _______________________________________________
> >>>> sakai-ui-dev mailing list
> >>>> sakai-ui-dev at collab.sakaiproject.org
> >>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-ui-dev
> >>>>
> >>>
> >>>
> >>> _______________________________________________
> >>> sakai-ui-dev mailing list
> >>> sakai-ui-dev at collab.sakaiproject.org
> >>> http://collab.sakaiproject.org/mailman/listinfo/sakai-ui-dev
> >>>
> >>>
> >>
> >>
> >> --
> >>
> >> Alan Marks
> >> Sakai OAE Project Director
> >> skype: skramnala
> >> _______________________________________________
> >> sakai-ui-dev mailing list
> >> sakai-ui-dev at collab.sakaiproject.org
> >> http://collab.sakaiproject.org/mailman/listinfo/sakai-ui-dev
> >>
> >
> >
> > _______________________________________________
> > sakai-ui-dev mailing list
> > sakai-ui-dev at collab.sakaiproject.org
> > http://collab.sakaiproject.org/mailman/listinfo/sakai-ui-dev
> >
> _______________________________________________
> sakai-ui-dev mailing list
> sakai-ui-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-ui-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-ui-dev/attachments/20110815/75f44b98/attachment-0001.html