[cle-kernel-team] default properties cleanup

[Steve Swinsburg]

Hi Aaron,

The change I made was to restore portalPath=/portal in default.sakai.properties. This is part of the config module and jenkins has no bearing on this as the config module is all source code, there is no assembly. That is where the property was removed from, that is where I put it back.

I wasn't prepared to wait.  Sakai was broken, trunk was unusable and people were unable to do any work. This broke on the 26th February, JIRA here:
https://jira.sakaiproject.org/browse/SAK-21843

The fix you put in place yesterday, was 10 days later.

I put a fix in place to get things back on the road. If you wanted to remove the property from that location and move it to kernel.properties (which you've done in that Jira) then it should not have been committed until it was all in place.

As for this particular email, I don't see any other revert commits to default.sakai.properties or kernel.properties apart from your ones yesterday, which specifically mention my change, so I can only presume that this email was specifically addressed at me:
https://source.sakaiproject.org/viewsvn/config/trunk/configuration/bundles/src/bundle/org/sakaiproject/config/bundle/default.sakai.properties?view=log
https://source.sakaiproject.org/viewsvn/kernel/trunk/component-manager/src/main/bundle/org/sakaiproject/config/kernel.properties?sortby=date&view=log

In that case, there are more appropriate avenues for raising issues like this.

thanks,
Steve


On 07/03/2012, at 8:52 AM, Aaron Zeckoski wrote:

> There were a few.
> 
> Since you ask, in your case specifically:
> It was tested but the issues with the assemblies mean that one often
> has to wait for a jenkins build to complete before one will see new
> changes in kernel. Since the kernel was not able to rebuild because of
> sonatype issues, this meant a multi-day delay. Matt Jones can exaplin
> that if you are curious. When there is time I plan to eliminate the
> assemblies to eliminate issues like this but that's a big effort which
> there is no time for right now.
> 
> A better fix (if you could not wait for the kernel rebuild) would have
> been to fix the areas which were accessing the property, though I
> happen to know there are over 100 of them so that's not really viable.
> In this case the only real fix was to simply be patient.
> 
> As you can see, nightly2 is currently working fine after I reverted
> your change so we just need to be more careful about undoing other
> peoples code without contacting them (especially in cases where the
> change is not actually a fix or necessary).
> 
> Thanks
> -AZ
> 
> 
> On Tue, Mar 6, 2012 at 4:12 PM, Steve Swinsburg
> <steve.swinsburg at gmail.com> wrote:
>> Which issues are you referring to Aaron?
>> 
>> I am responsible for one, but it was a single line change to restore a property that was commented out, and presumably not tested before being committed.
>> 
>> No one could login to Sakai without this property being restored, or the portal being reworked to fix it.
>> 
>> Thanks
>> Steve
>> 
>> Sent from my iPhone
>> 
>> On 07/03/2012, at 1:22, Aaron Zeckoski <azeckoski at unicon.net> wrote:
>> 
>>> Hey guys,
>>> Please do me a favor and don't go around undoing my efforts to cleanup
>>> the kernel and default properties files. It's a long process and it is
>>> made harder by others hacking in fixes while I am trying to do the
>>> overall cleanup effort.
>>> If something breaks related to the props cleanup then please post a
>>> message about it or email me or something but please do not just go
>>> putting the property back in the default properties file.
>>> Thanks
>>> -AZ
>>> 
>>> 
>>> --
>>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>>> _______________________________________________
>>> cle-kernel-team mailing list
>>> cle-kernel-team at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/cle-kernel-team
> 
> 
> 
> -- 
> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile