[cle-kernel-team] default properties cleanup
azeckoski at unicon.net
Tue Mar 6 13:52:35 PST 2012
There were a few.
Since you ask, in your case specifically:
It was tested but the issues with the assemblies mean that one often
has to wait for a jenkins build to complete before one will see new
changes in kernel. Since the kernel was not able to rebuild because of
sonatype issues, this meant a multi-day delay. Matt Jones can exaplin
that if you are curious. When there is time I plan to eliminate the
assemblies to eliminate issues like this but that's a big effort which
there is no time for right now.
A better fix (if you could not wait for the kernel rebuild) would have
been to fix the areas which were accessing the property, though I
happen to know there are over 100 of them so that's not really viable.
In this case the only real fix was to simply be patient.
As you can see, nightly2 is currently working fine after I reverted
your change so we just need to be more careful about undoing other
peoples code without contacting them (especially in cases where the
change is not actually a fix or necessary).
On Tue, Mar 6, 2012 at 4:12 PM, Steve Swinsburg
<steve.swinsburg at gmail.com> wrote:
> Which issues are you referring to Aaron?
> I am responsible for one, but it was a single line change to restore a property that was commented out, and presumably not tested before being committed.
> No one could login to Sakai without this property being restored, or the portal being reworked to fix it.
> Sent from my iPhone
> On 07/03/2012, at 1:22, Aaron Zeckoski <azeckoski at unicon.net> wrote:
>> Hey guys,
>> Please do me a favor and don't go around undoing my efforts to cleanup
>> the kernel and default properties files. It's a long process and it is
>> made harder by others hacking in fixes while I am trying to do the
>> overall cleanup effort.
>> If something breaks related to the props cleanup then please post a
>> message about it or email me or something but please do not just go
>> putting the property back in the default properties file.
>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>> cle-kernel-team mailing list
>> cle-kernel-team at collab.sakaiproject.org
Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
More information about the cle-kernel-team